Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix severe performance regression with gettext 0.20+ on Windows
Date: 2025-12-15 18:23:41
Message-ID: CA+hUKGK_cZkYDFJ7SgPfS_TxqFczM_HpNyLxg9vJdMrg1jum+Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 10, 2025 at 1:45 PM Bryan Green <dbryan(dot)green(at)gmail(dot)com> wrote:
> 1. Locale format mismatch
> gettext 0.20.1+ introduced a get_lcid() function that expects Windows
> locale format ("English_United States.1252") rather than POSIX format
> ("en_US"). This function enumerates all Windows locales (~259) until a
> match is found, then uses the resulting LCID to determine the catalog path.

I'm surprised there isn't a fast path that skips all that deprecated
(?) stuff when you use BCP 47 language codes...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-12-15 18:28:06 Re: PRI?64 vs Visual Studio (2022)
Previous Message vignesh C 2025-12-15 18:05:35 pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects