Re: Yet another fast GiST build

On Mon, Dec 30, 2019 at 7:43 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> PFA rebased patch.

Hi Andrey,

This looks really interesting, and I am sure there are a lot of GIS
people who would love to see dramatically faster and smaller indexes
in PG13. I don't know enough to comment on the details, but here are
some superficial comments:

+ method is also optional and is used diring fast GiST build.

-> during

+ /* esteblish order between x and y */

-> establish

+/* Compute Z-oder for point */
static inline uint64
point_zorder_internal(Point *p)

-> order

Could this function please have a comment that explains why it works?
I mean, just a breadcrumb... the name of the technique or something...
so that uninitiated hackers can google their way to a clue (is it
"Morton encoding"?)

MSVC says:

src/backend/access/gist/gistproc.c(1582): error C2065: 'INT32_MAX' :
undeclared identifier

GCC says:

gistbuild.c: In function ‘gist_indexsortbuild’:
gistbuild.c:256:4: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
IndexTuple *itvec = gistextractpage(lower_page, &vect_len);
^