Re: Windows question: when is LC_MESSAGES defined?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Windows question: when is LC_MESSAGES defined?
Date: 2025-07-10 03:45:13
Message-ID: CA+hUKGKXWG5_cnYGcu=fh+=zdZXTKNbi0fp6r2XDvhgz4Cqh0A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 10, 2025 at 5:32 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> I was trying to exercise the function IsoLocaleName(), which is
> surrounded by:
>
> #if defined(WIN32) && defined(LC_MESSAGES)
>
> but, at least in CI, that combination never seems to be true, which
> surprised me. What platforms exercise this code path?

.cirrus.tasks.yml says:

# disable -Dnls as the number of files it creates cause a noticable
slowdown...

configure_script: |
%BASH% -c "meson setup -Ddebug=true -Doptimization=g
-Dcassert=true -Dinjection_points=true -Db_pch=true -Dnls=disabled
-DTAR=%TAR% build"

If you turn that on then the next problem to solve is:

[03:28:24.318] Program msgfmt found: NO

It gets past that and enables NLS and compiles that code in the
optional MinGW build (assuming you enable it in meson).

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-07-10 03:47:51 Re: support create index on virtual generated column.
Previous Message Michael Paquier 2025-07-10 03:31:22 Re: Fix comment in btree_gist--1.8--1.9.sql