Re: Collation versioning

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Subject: Re: Collation versioning
Date: 2020-11-04 02:20:47
Message-ID: CA+hUKGKRUi9kASpq8b6hvG6D+_eddKeks0TR98YkufYBTEN6Mw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 4, 2020 at 2:56 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> initdb works fine. I ran vcregress upgradecheck and it passes.
>
> With my default locale of English.New Zealand.1252 I get zero rows from:
>
> select * from pg_depend where coalesce(refobjversion,'') <> '';
>
> if I initdb with --lc-collate=en-NZ, it works and I see:
>
> postgres=# select * from pg_depend where coalesce(refobjversion,'') <> '';
> classid | objid | objsubid | refclassid | refobjid | refobjsubid |
> deptype | refobjversion
> ---------+-------+----------+------------+----------+-------------+---------+-----------------
> 2606 | 12512 | 0 | 3456 | 100 | 0 | n
> | 1538.14,1538.14
> (1 row)

Thanks for all the help and testing! Pushed. If we don't come up
with something better I'll need to figure out how to explain this in
the manual. (Will no one rid us of these meddlesome old format locale
names? It seems like pg_locale.c could drop a lot of rather
unpleasant code if initdb, CREATE COLLATION, and CREATE DATABASE
didn't allow them into the catalogue in the first place...)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-11-04 02:32:18 Re: ModifyTable overheads in generic plans
Previous Message Tomas Vondra 2020-11-04 01:57:05 Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843