Re: POC: Cleaning up orphaned files using undo logs

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: POC: Cleaning up orphaned files using undo logs
Date: 2019-09-16 22:03:20
Message-ID: CA+hUKGKBRVx3CkZoP_CTMBtuHQg1Rx0Y+PYpQPNH_V9PgqB3Ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 17, 2019 at 3:09 AM Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
> On Mon, Sep 16, 2019 at 11:23 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Agreed. I added a line to break out of that loop if !block->in_use.
> >
> I think we should skip the block if !block->in_use. Because, the undo
> buffer can be registered in a subsequent block as well. For different
> operations, we can use different block_id to register the undo buffer
> in the redo record.

Oops, right. So it should just be added to the if condition. Will do.

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2019-09-16 22:39:40 Re: Define jsonpath functions as stable
Previous Message Alvaro Herrera 2019-09-16 21:45:31 Re: [PATCH][PROPOSAL] Add enum releation option type