Re: Dead code in ps_status.c

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Banck <mbanck(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Dead code in ps_status.c
Date: 2025-11-10 22:04:00
Message-ID: CA+hUKGK8ib-QCO-+vOyUj0R-59P69MXEy7kWskd_xd3r3dXSYA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Replying to Michael's message:

https://www.postgresql.org/message-id/68adbcd3.500a0220.8d4c9.9460%40mx.google.com

Sorry I missed this. I had some trouble with your messages being
deleted as spam, which I've hopefully fixed now...

-#elif defined(__linux__) || defined(__sun) || defined(__darwin__)
+#elif defined(__linux__) || defined(__sun) || defined(__darwin__) ||
defined(__GNU__)

Would __gnu_hurd__ be a better bet, less confusable with GNU userspace
stuff? I think these platform macros might come from this file in
GCC:

https://github.com/gcc-mirror/gcc/blob/faf7053346110cbd11fb22ff75f56a964047b19c/gcc/config/gnu.h#L30

But maybe not only there, if __hurd__ (as removed by d2ea2d31)
actually worked...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-10 22:32:43 Re: Serverside SNI support in libpq
Previous Message Michael Banck 2025-11-10 21:48:52 Re: GNU/Hurd portability patches