| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fairywren hung in pg_basebackup tests |
| Date: | 2022-07-28 02:12:13 |
| Message-ID: | CA+hUKGK5pbVbW2LL=ktJWhSE5_oYfbmC1iU1y0daBtm+HMN4sQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 28, 2022 at 12:41 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I thought about putting it at the top, but don't we really only need
> to make an extra system call if MinGW's stat() told us it saw a
> directory? And what if you asked to look through symlinks? I thought
> about putting it near the S_ISLNK() test, which is the usual pattern,
> but then what if MinGW decides to add d_type support one day? Those
> thoughts led to the attached formulation. Untested. I'll go and try
> to see if I can run this with Melih's proposed MSYS CI support...
Success. I'll push this, and then hopefully those BF animals can be
unwedged. (I see some unrelated warnings to look into.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-07-28 02:17:49 | Re: Official Windows Installer and Documentation |
| Previous Message | Masahiko Sawada | 2022-07-28 02:11:15 | Re: Improve description of XLOG_RUNNING_XACTS |