Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Date: 2022-04-22 21:12:20
Message-ID: CA+hUKGJwUJ7sT4ehZmHeh_0h1y0nFm7c07Gsmv120AR=gZA+sQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Apr 23, 2022 at 8:06 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Sure, see also http://postgr.es/m/CA+TgmoYRGUcFBy6VgN0+Pn4f6Wv=2H0HZLuPHqSy6VC8Ba7vdg@mail.gmail.com
> where Andrew's opinion on how to fix this was sought.
>
> I have to say the fact that IPC::Run does shell-glob expansion of its
> arguments on some machines and not others seems ludicrous to me. This
> patch may be overtested, but such a radical behavior difference is
> completely nuts. How is anyone supposed to write reliable tests for
> any feature in the face of such wildly inconsistent behavior?

Yeah, I was speculating that it's a bug in IPC::Run that has been
fixed (by our very own Noah), and some of the machines are still
running the buggy version.

(Not a Windows person, but I speculate the reason that such a stupid
bug is even possible may be that Windows lacks a way to 'exec' stuff
with a passed-in unadulterated argv[] array, so you always need to
build a full shell command subject to interpolation, so if you're
trying to emulate an argv[]-style interface you have to write the code
to do the escaping, and so everyone gets a chance to screw that up.)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-22 23:08:05 Re: pgsql: Remove some recently-added pg_dump test cases.
Previous Message Robert Haas 2022-04-22 20:20:34 pgsql: Remove some recently-added pg_dump test cases.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Christensen 2022-04-22 22:51:24 [PATCH] Teach pg_waldump to extract FPIs from the WAL
Previous Message Robert Haas 2022-04-22 20:06:03 Re: pgsql: Allow db.schema.table patterns, but complain about random garbag