From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. |
Date: | 2023-02-24 00:56:05 |
Message-ID: | CA+hUKGJvJe0kjxXJ8b2mEibHFX2q69rJTQLq-WxiyW-JvErFmQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> These patches cause warnings under MSVC.
>
> Of course my patch to improve CI by warning about compiler warnings is
> the only one to notice.
>
> https://cirrus-ci.com/task/6199582053367808
It's a shame that it fails the whole Windows task, whereas for the
Unixen we don't do -Werror so you can still see if everything else is
OK, but then we check for errors in a separate task. I don't have any
ideas on how to achieve that, though.
FWIW my CI log scanner also noticed this problem
http://cfbot.cputube.org/highlights/compiler.html. Been wondering how
to bring that to the right people's attention. Perhaps by adding a
clickable ⚠ to the main page next to the item if any of these
"highlights" were detected; perhaps it should take you to a
per-submission history page with the highlights from each version.
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2023-02-24 01:07:16 | Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. |
Previous Message | Justin Pryzby | 2023-02-24 00:20:29 | Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2023-02-24 01:07:16 | Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. |
Previous Message | Thomas Munro | 2023-02-24 00:25:01 | Re: stopgap fix for signal handling during restore_command |