Re: Add client connection check during the execution of the query

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add client connection check during the execution of the query
Date: 2019-07-18 04:28:14
Message-ID: CA+hUKGJtJM91cWqTby=EX=63ERjB5PumdSWKKmamLBE-QLXE+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 18, 2019 at 3:19 PM Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
> So the performance is about 5% down with the feature enabled in this
> case. For me, 5% down is not subtle. Probably we should warn this in
> the doc.

Yeah, the timer logic is wrong. I didn't have time to look into it
but with truss/strace for some reason I see 3 setitimer() syscalls for
every query, but I think this doesn't even need to set the timer for
every query.

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2019-07-18 04:43:08 Re: Add client connection check during the execution of the query
Previous Message Asim R P 2019-07-18 04:08:13 Re: ERROR after writing PREPARE WAL record