| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up historical portability baggage |
| Date: | 2022-08-04 04:30:26 |
| Message-ID: | CA+hUKGJqPCK4AmCJJASYaApMscvd8q7NSOBCq0DtkWQz-pMXNQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 4, 2022 at 3:43 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > We retain a HAVE_SHM_OPEN macro, because it's clearer to readers than
> > something like !defined(WIN32).
>
> I don't like these. I don't find them clearer - if we really just assume this
> to be the case on windows, it's easier to understand the checks if they talk
> about windows rather than having to know whether this specific check just
> applies to windows or potentially an unspecified separate set of systems.
>
> But I guess I should complain upthread...
Thanks for reviewing.
For this point, I'm planning to commit with those "vestigial" macros
that Tom asked for, and then we can argue about removing them
separately later.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-08-04 05:19:47 | Re: Cygwin cleanup |
| Previous Message | Bharath Rupireddy | 2022-08-04 04:27:48 | Re: Generalize ereport_startup_progress infrastructure |