Re: wake up logical workers after ALTER SUBSCRIPTION

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: 2022-11-30 04:27:40
Message-ID: CA+hUKGJXO6LUn3wTf3s0Z8DvgbQROxPTnJDHCsQrhbr3pF3g8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 30, 2022 at 5:23 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Nov 30, 2022 at 5:10 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> > I spent some more time on the prevent-unnecessary-wakeups patch for
> > logical/worker.c that I've been alluding to in this thread, and I found a
> > few more places where we depend on the worker periodically waking up. This
> > seems to be a common technique, so I'm beginning to wonder whether these
> > changes are worthwhile. I think there's a good chance it would become a
> > game of whac-a-mole.
>
> Aren't they all bugs, though, making our tests and maybe even real
> systems slower than they need to be?

(Which isn't to suggest that it's your job to fix them, but please do
share what you have if you run out of whack-a-mole steam, since we
seem to have several people keen to finish those moles off.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-11-30 04:39:05 pg_dump bugs reported as pg_upgrade bugs
Previous Message Thomas Munro 2022-11-30 04:23:16 Re: wake up logical workers after ALTER SUBSCRIPTION