Re: Broken make dependency somewhere near win32ver.o?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Broken make dependency somewhere near win32ver.o?
Date: 2022-03-22 05:09:08
Message-ID: CA+hUKGJWQSdxC1vcYpcZydaoA6j=C7yOeG5UHE7KSVfoHzP9tg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 22, 2022 at 4:14 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> The problem looks to be that pg_dumpall doesn't have a dependency on OBJs,
> which in turn is what contains the dependency on WIN32RES, which in turn
> contains win32ver.o. So the build succeeds if pg_dump/restores's dependencies
> are built first, but not if pg_dumpall starts to be built before that...
>
> Seems we just need to add $(WIN32RES) to pg_dumpall: ?

Ah, yeah, that looks right. I don't currently have a mingw setup to
test, but clearly $(WIN32RES) is passed to $(CC) despite not being
listed as a dependency.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2022-03-22 07:08:43 Skipping schema changes in publication
Previous Message Dilip Kumar 2022-03-22 05:06:30 Re: Add sub-transaction overflow status in pg_stat_activity