| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade test failure |
| Date: | 2022-10-02 20:07:25 |
| Message-ID: | CA+hUKGJSkt3nx35uwpYX8D+cAZT38gk++btCp2Tz+uibH+Y1PA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Sep 20, 2022 at 1:31 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> I suspect that rmtree() was looping in pgunlink(), and got ENOENT, so
> didn't warn about the file itself, but then failed one moment later in
> rmdir.
Yeah, I think this is my fault. In commit f357233c the new lstat()
call might return ENOENT for STATUS_DELETE_PENDING, and then we don't
enter pgunlink()'s 10 second sleep-retry loop. Let me think about how
best to fix that, and how to write a regression test program that
would exercise stuff like this. Might take a couple of days as I am
away from computers until mid-week.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-10-02 23:10:06 | Re: pg_upgrade test failure |
| Previous Message | Andres Freund | 2022-10-02 15:46:43 | Re: pg_upgrade test failure |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-10-02 20:22:01 | Re: disfavoring unparameterized nested loops |
| Previous Message | Tom Lane | 2022-10-02 19:10:19 | Re: Question: test "aggregates" failed in 32-bit machine |