Re: Using condition variables to wait for checkpoints

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using condition variables to wait for checkpoints
Date: 2019-04-05 09:05:02
Message-ID: CA+hUKGJKbCd+_K+SEBsbHxVT60SG0ivWHHAdvL0bLTUt2xpA2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 14, 2019 at 11:05 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I renamed the CVs because the names I had used before broke the
> convention that variables named ckpt_* are protected by ckpt_lck, and
> pushed.

Erm... this made successful checkpoints slightly faster but failed
checkpoints infinitely slower. It would help if we woke up CV waiters
in the error path too. Patch attached.

--
Thomas Munro
https://enterprisedb.com

Attachment Content-Type Size
0001-Wake-up-interested-backends-when-a-checkpoint-fails.patch text/x-patch 1002 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message GUO Rui 2019-04-05 09:07:10 Re: Google Summer of Code: question about GiST API advancement project
Previous Message Michael Banck 2019-04-05 08:39:26 Re: pg_rewind vs superuser