Re: fairywren is generating bogus BASE_BACKUP commands

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fairywren is generating bogus BASE_BACKUP commands
Date: 2022-01-22 03:43:38
Message-ID: CA+hUKGJKTR3mu2Z_CXNqKYRFqc3dzC7a+RtbA8BYU0ansxDT3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 22, 2022 at 3:55 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jan 21, 2022 at 5:35 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > # See https://www.msys2.org/wiki/Porting/#filesystem-namespaces
> > local $ENV{MSYS2_ARG_CONV_EXCL} = $source_ts_prefix;
> > Probably in this case just setting it to 'server:' would do the trick.
>
> Oh, thanks for the tip. Do you want to push a commit that does that,
> or ... should I do it?

Just a thought: Would it prevent the magic path translation and all
just work if the path were already in Windows form? So, if we did
just this change at the top:

-my $tempdir = PostgreSQL::Test::Utils::tempdir;
+my $tempdir = PostgreSQL::Test::Utils::perl2host(PostgreSQL::Test::Utils::tempdir);

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-01-22 04:04:01 Re: Schema variables - new implementation for Postgres 15
Previous Message vrund shah 2022-01-22 03:23:00 Re: How to get started with contribution