Re: Collation versions on Windows (help wanted, apply within)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Collation versions on Windows (help wanted, apply within)
Date: 2020-03-25 03:18:17
Message-ID: CA+hUKGJH2LvG9xLgWyERUBXMcBzNS2NzopJOR9VP92XgJHNKcQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 24, 2020 at 7:56 AM Juan José Santamaría Flecha
<juanjo(dot)santamaria(at)gmail(dot)com> wrote:
> On Mon, Mar 23, 2020 at 5:59 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> Done in this new 0002 patch (untested). 0001 removes the comment that
>> individual collations can't have a NULL version, reports NULL for
>> Linux/glibc collations like C.UTF-8 by stripping the suffix and
>> comparing with C and POSIX as suggested by Peter E.
>
> It applies and passes tests without a problem in Windows, and works as expected.

Thanks! Pushed.

From the things we learned in this thread, I think there is an open
item for someone to write a patch to call EnumSystemLocalesEx() and
populate the initial set of collations, where we use "locale -a" on
Unix. I'm not sure where the encoding is supposed to come from
though, which is why I didn't try to write a patch myself.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-03-25 03:19:22 Re: error context for vacuum to include block number
Previous Message Amit Kapila 2020-03-25 03:02:39 Re: improve transparency of bitmap-only heap scans