From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: kevent latch paths don't handle postmaster death well |
Date: | 2020-10-14 22:50:18 |
Message-ID: | CA+hUKG+z9NtH8j7JLfX-issbQHUb5vCWw+aEpmxxEZ6=mV-Wjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 15, 2020 at 11:18 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > On Thu, Oct 15, 2020 at 8:40 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Seems like having that be per-WaitEventSet state is also not a great
> >> idea --- if we detect PM death while waiting on one WES, and then
> >> wait on another one, it won't work. A plain process-wide static
> >> variable would be a better way I bet.
>
> > I don't think that's a problem -- the kernel will report the event to
> > each interested kqueue object. The attached fixes the problem for me.
>
> Oh, OK. I confirm this makes the kqueue path work like the EPOLL and POLL
> paths. (I can't test the WIN32 path.)
Thanks. Pushed.
(Hmm, I wonder about that Windows process exit event.)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-14 22:57:22 | Re: kevent latch paths don't handle postmaster death well |
Previous Message | Tom Lane | 2020-10-14 22:18:53 | Re: kevent latch paths don't handle postmaster death well |