Re: Grouping isolationtester tests in the schedule

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Grouping isolationtester tests in the schedule
Date: 2019-08-07 11:42:02
Message-ID: CA+hUKG+sdF7pE9cdFLXwKRL99TOdNLeDtBHepRL5d5WPvBT2FQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 7, 2019 at 11:28 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> The list of tests in src/test/isolation/isolation_schedule has grown
> over the years. Originally, they were all related to Serializable
> Snapshot Isolation, but there are different kinds of concurrency tests
> there now. More tests is good, but the schedule file has grown into a
> big inscrutable list with zero comments.

+1

> I propose to categorize the tests and add some divider comments to the
> file, see attached.

I think I'd put nowait and skip locked under a separate category "FOR
UPDATE" or "row locking" or something, but maybe that's just me... can
you call that stuff DML?

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2019-08-07 12:09:24 Re: s/rewinded/rewound/?
Previous Message Thomas Munro 2019-08-07 11:35:38 Re: POC: Cleaning up orphaned files using undo logs