Re: GROUP BY DISTINCT

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Vik Fearing <vik(at)postgresfriends(dot)org>, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: GROUP BY DISTINCT
Date: 2021-03-18 21:02:53
Message-ID: CA+hUKG+rJkXWjj_WFPE8cDp+9Av2T3bQfEfEBd=W+PdWVCk8mg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

On Fri, Mar 19, 2021 at 8:27 AM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> Hmmm, this seems to fail on lapwing with this error:
>
> parse_agg.c: In function 'expand_grouping_sets':
> parse_agg.c:1851:23: error: value computed is not used
> [-Werror=unused-value]
> cc1: all warnings being treated as errors
>
> That line is this:
>
> foreach_delete_current(result, cell);
>
> and I don't see how any of the values close by could be unused ...
>
> The only possibility I can think of is some sort of issue in the old-ish
> gcc release (4.7.2).

No sure what's going on there, but data points: I tried a 32 bit build
here (that's the other special thing about lapwing) and didn't see the
warning. GCC 10. Also curculio (gcc 4.2) and snapper (gcc 4.7) are
also showing this warning, but they don't have -Werror so they don't
fail. sidewinder (gcc 4.8) is not showing the warning.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Tomas Vondra 2021-03-18 21:14:03 Re: GROUP BY DISTINCT
Previous Message Tomas Vondra 2021-03-18 19:27:40 Re: GROUP BY DISTINCT

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-03-18 21:04:55 Re: New IndexAM API controlling index vacuum strategies
Previous Message Euler Taveira 2021-03-18 21:00:14 Re: cleanup temporary files after crash