Re: A micro-optimisation for walkdir()

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A micro-optimisation for walkdir()
Date: 2020-09-07 11:40:47
Message-ID: CA+hUKG+mkrvPawBah67YveZtz1TYMa3FxsOC+dgt1tN6DaKnzw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 7, 2020 at 9:42 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Mon, Sep 7, 2020 at 12:27 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> I think the following is a little mysterious, but it does seem to be
>> what people do for this in other projects. It is the documented way
>> to detect mount points, and I guess IO_REPARSE_TAG_MOUNT_POINT is
>> either overloaded also for junctions, or junctions are the same thing
>> as mount points. It would be nice to see a Win32 documentation page
>> that explicitly said that.
>
> The wikipedia page on it is actually fairly decent: https://en.wikipedia.org/wiki/NTFS_reparse_point. It's not the documentation of course, but it's easier to read :) The core difference is whether you mount a whole filesystem (mount point) or just a directory off something mounted elsehwere (junction).
>
> And yes, the wikipedia page confirms that junctions also use IO_REPARSE_TAG_MOUNT_POINT.

Thanks for confirming. I ran the Windows patch through pgindent,
fixed a small typo, and pushed.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Himanshu Upadhyaya 2020-09-07 12:03:49 Inaccurate comment, for family-1 polymorphic UNKNOWN type arguments
Previous Message Andrey V. Lepikhov 2020-09-07 11:37:00 Re: Ideas about a better API for postgres_fdw remote estimates