From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: refactoring - share str2*int64 functions |
Date: | 2019-07-08 03:22:31 |
Message-ID: | CA+hUKG+kRsUt26BA-JPnfQq71V0Udyi0yVcc3nS9Jx8_xrDe4g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, May 24, 2019 at 3:23 AM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> >> Although I agree it is not worth a lot of trouble, and even if I don't do
> >> Windows, I think it valuable that the behavior is the same on all platform.
> >> The attached match shares pg_str2*int64 functions between frontend and
> >> backend by moving them to "common/", which avoids some code duplication.
> >>
> >> This is more refactoring, and it fixes the behavior change on 32 bit
> >> architectures.
>
> V2 is a rebase.
Hi Fabien,
Here's some semi-automated feedback, noted while going through
failures on cfbot.cputube.org. You have a stray editor file
src/backend/parser/parse_node.c.~1~. Something is failing to compile
while doing the temp-install in make check-world, which probably
indicates that some test or contrib module is using the interface you
changed?
--
Thomas Munro
https://enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2019-07-08 03:45:49 | Re: allow_system_table_mods stuff |
Previous Message | Thomas Munro | 2019-07-08 03:15:35 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |