From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version(). |
Date: | 2021-02-23 07:23:19 |
Message-ID: | CA+hUKG+im982D-TxHPU=cq=j=GLwFaFvDx8=2JUtwJxj=Fp5LA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 22.02.21 12:28, Thomas Munro wrote:
> > pg_collation_actual_version() -> pg_collation_current_version().
> >
> > The new name seems a bit more natural.
> >
> > Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com
>
> I don't find where this change was discussed in that thread. I
> specifically chose that name to indicate, "not the current version in
> the database, but the version the OS thinks it should be". I think the
> rename loses that distinction.
I understood "actual" to be a way of contrasting with
pg_collation.collversion, which we dropped. Without that, the meaning
of a more typical function name with "current" seemed clearer to me,
and "actual" seemed excessively emphatic. There isn't a concept of a
single "current version in the database" anymore, there's just the set
of relevant versions that were current when each index was built.
Happy to revert the name change if you hate it though, and sorry I
didn't CC you on the thread.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-02-23 09:30:07 | pgsql: Simplify printing of LSNs |
Previous Message | Peter Eisentraut | 2021-02-23 06:03:12 | Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version(). |
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2021-02-23 08:04:47 | Re: pg_temp_%d namespace creation can invalidate all the cached plan in other backends |
Previous Message | Dilip Kumar | 2021-02-23 06:33:32 | Re: Is Recovery actually paused? |