| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch to allow disable of WAL recycling |
| Date: | 2019-04-02 01:48:01 |
| Message-ID: | CA+hUKG+cmSmEnPxOkoFCXaDobqmq1p13YMndmwtLD7+93ZgvRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 30, 2019 at 11:18 AM Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com> wrote:
> I went through your new version of the patch and it all looks great to me.
I moved the error handling logic around a bit so we'd capture errno
immediately after the syscalls. I also made a couple of further
tweaks to comments and removed some unnecessary casts.
I suspect we took so long on this because of lack of ZFS knowledge and
uncertainty about the precise reason for the current coding in terms
of crash safety in general. After learning more, I now suspect the
claim about fsyncdata(2) and indirect blocks in the comments may be
incorrect (it may stem from buggy behaviour on older Linux kernels),
but I'm not sure and it's not this patch's job to change that.
Pushed. Thanks for the patch!
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-02 02:05:56 | Re: Progress reporting for pg_verify_checksums |
| Previous Message | Andres Freund | 2019-04-02 01:26:59 | Re: pgsql: Compute XID horizon for page level index vacuum on primary. |