Re: InstallXLogFileSegment() vs concurrent WAL flush

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: InstallXLogFileSegment() vs concurrent WAL flush
Date: 2024-02-02 13:42:46
Message-ID: CA+hUKG+bk2BO282C1DaZ7PLUyxkShNLc2iPyiHEWhR=gS4gmpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 2, 2024 at 12:56 PM Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> On Fri, 2 Feb 2024 11:18:18 +0100
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > One simple way to address that would be to make XLogFileInitInternal()
> > wait for InstallXLogFileSegment() to finish. It's a little
>
> Or, can we make sure the rename is durable by calling fsync before
> returning the fd, as a patch attached here?

Right, yeah, that works too. I'm not sure which way is better.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-02-02 13:52:50 Re: XLog size reductions: smaller XLRec block header for PG17
Previous Message Heikki Linnakangas 2024-02-02 12:41:18 Re: POC: Extension for adding distributed tracing - pg_tracing