Re: Cygwin cleanup

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Cygwin cleanup
Date: 2022-12-06 20:35:35
Message-ID: CA+hUKG+bb9qMF125u5AR4Y02WiphJZ+42ezv8sLOM9VmrEio=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 29, 2022 at 10:57 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I wonder if these problems would go away as a nice incidental
> side-effect if we used latches for postmaster wakeups. I don't
> know... maybe, if the problem is just with the postmaster's pattern of
> blocking/unblocking? Maybe backend startup is simple enough that it
> doesn't hit the bug? From a quick glance, I think the assertion
> failures that occur in regular backends can possibly be blamed on the
> postmaster getting confused about its children due to unexpected
> handler re-entry.

Just to connect the dots, that's what this patch does:

https://www.postgresql.org/message-id/flat/CA+hUKG+Z-HpOj1JsO9eWUP+ar7npSVinsC_npxSy+jdOMsx=Gg(at)mail(dot)gmail(dot)com

(There may be other places that break under Cygwin's flaky sa_mask
implementation, I don't know and haven't seen any clues about that.)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2022-12-06 21:00:38 Re: [PATCH] Infinite loop while acquiring new TOAST Oid
Previous Message Tom Lane 2022-12-06 20:29:15 Re: Error-safe user functions