| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Array initialisation notation in syscache.c |
| Date: | 2022-12-21 03:16:27 |
| Message-ID: | CA+hUKG+VyAixBPPL8xP8TgLY5NvOBuZKy+=KUB7xSFuHOyP83w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 21, 2022 at 1:33 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> KEY(Anum_pg_attribute_attrelid,
> Anum_pg_attribute_attnum),
I independently rediscovered that our VA_ARGS_NARGS() macro in c.h
always returns 1 on MSVC via trial-by-CI. Derp. Here is the same
patch, no change from v2, but this time accompanied by Victor Spirin's
fix, which I found via one of the tab-completion-is-busted-on-Windows
discussions. I can't supply a useful commit message, because I
haven't understood why it works, but it does indeed seem to work and
this should make cfbot green.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-VA_ARGS_NARGS-macro-on-MSVC.patch | text/x-patch | 1.5 KB |
| v3-0002-Improve-notation-of-cacheinfo-table-in-syscache.c.patch | text/x-patch | 23.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takamichi Osumi (Fujitsu) | 2022-12-21 03:28:01 | assertion failures on BuildFarm that happened in slab.c |
| Previous Message | Peter Geoghegan | 2022-12-21 03:15:33 | Re: New strategies for freezing, advancing relfrozenxid early |