| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2020-10-12 11:37:40 |
| Message-ID: | CA+hUKG+JK=tfN3=rS2wvqwQiCSqqT1fjhk6P1_F5+aKoi=b0KQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 12, 2020 at 6:35 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> On Mon, Oct 12, 2020 at 2:11 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Yeah, I think we should go ahead and fix that up front. Here's a
> > version with a commit message.
>
> I've checked it and tested it, and it looks fine to me.
> Also, it seems to align with the gripe in the old comment about width
> ("XXX this is totally wrong: we should report zero if no RETURNING
> ...").
> I'm happy for you to commit it.
Pushed, though I left most of that comment there because the width
estimate still needs work when you do use RETURNING. At least we now
have rows=0 for queries without RETURNING, which was a bigger problem
for your patch.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hou, Zhijie | 2020-10-12 11:42:31 | RE: Remove some unnecessary if-condition |
| Previous Message | Michael Paquier | 2020-10-12 11:36:07 | Re: speed up unicode normalization quick check |