| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dag Lem <dag(at)nimrod(dot)no>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: daitch_mokotoff module |
| Date: | 2022-01-03 01:47:05 |
| Message-ID: | CA+hUKG+Gs3WXzbT4OK9gEXpC1e221RafrPS4LVvcDDgDi20xAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 3, 2022 at 10:32 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2021-12-21 22:41:18 +0100, Dag Lem wrote:
> > This is my very first code contribution to PostgreSQL, and I would be
> > grateful for any advice on how to proceed in order to get the patch
> > accepted.
>
> Currently the tests don't seem to pass on any platform:
> https://cirrus-ci.com/task/5941863248035840?logs=test_world#L572
> https://api.cirrus-ci.com/v1/artifact/task/5941863248035840/regress_diffs/contrib/fuzzystrmatch/regression.diffs
Erm, it looks like something weird is happening somewhere in cfbot's
pipeline, because Dag's patch says:
+SELECT daitch_mokotoff('Straßburg');
+ daitch_mokotoff
+-----------------
+ 294795
+(1 row)
... but it's failing like:
SELECT daitch_mokotoff('Straßburg');
daitch_mokotoff
-----------------
- 294795
+ 297950
(1 row)
It's possible that I broke cfbot when upgrading to Python 3 a few
months back (ie encoding snafu when using the "requests" module to
pull patches down from the archives). I'll try to fix this soon.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-03 02:41:53 | Re: daitch_mokotoff module |
| Previous Message | Tom Lane | 2022-01-02 23:22:23 | Re: Index-only scans vs. partially-retrievable indexes |