Re: Referential Integrity Checks with Statement-level Triggers

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Antonin Houska <ah(at)cybertec(dot)at>, emre(at)hasegeli(dot)com, Adam Brusselback <adambrusselback(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Referential Integrity Checks with Statement-level Triggers
Date: 2019-08-01 10:49:39
Message-ID: CA+hUKG+1UMa7TVAYdhH+u6uysS6ybsCA4RpxGAUGDFPVdranGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 26, 2019 at 5:41 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
>> In order to avoid per-row calls of the constraint trigger functions, we could
>> try to "aggregate" the constraint-specific events somehow, but I think a
>> separate queue would be needed for the constraint-specific events.
>>
>> In general, the (after) triggers and constraints have too much in common, so
>> separation of these w/o seeing code changes is beyond my imagination.
>
> Yeah, there's a lot of potential for overlap where a trigger could "borrow" an RI tuplestore or vice versa.
>
> The people who expressed opinions on nuking triggers from orbit (it's the only way to be sure) have yet to offer up any guidance on how to proceed from here, and I suspect it's because they're all very busy getting things ready for v12. I definitely have an interest in working on this for 13, but I don't feel good about striking out on my own without their input.

Very interesting thread, but the current patch has been through two
CFs without comments or new patches, so I'm going to mark it "Returned
with feedback". I hope all this discussion will trigger more research
in this space.

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-08-01 10:53:34 Re: [PATCH] Improve performance of NOTIFY over many databases (issue blocking on AccessExclusiveLock on object 0 of class 1262 of database 0)
Previous Message Julien Rouhaud 2019-08-01 10:37:44 Re: Avoid full GIN index scan when possible