Re: pg_upgrade test failure

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: pg_upgrade test failure
Date: 2023-02-06 21:51:20
Message-ID: CA+hUKG+08L=QNq8Zn6xG7f=m41=w=x52YViT6fyRMoCD9RnMzA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Feb 1, 2023 at 2:44 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> OK, I pushed that. Third time lucky?

I pulled down logs for a week of Windows CI, just over ~1k builds.
The failure rate was a few per day before, but there are no failures
like that after that went in. There are logs that contain the
"Directory not empty" warning, but clearly the
try-again-and-this-time-wait-for-the-other-process logic must be
working (as horrible as it is) because then the test checks that the
directory is gone, and succeeds. Hooray.

So that's one of our biggest CI flappers fixed. Unfortunately without
treating the root cause, really.

Next up: the new "running" tests, spuriously failing around 8.8% of CI
builds on FreeBSD. I'll go and ping that thread...

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-02-06 21:57:38 Re: pg_upgrade test failure
Previous Message Peter Eisentraut 2023-02-06 21:50:24 pgsql: Fix up outdated comments

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-02-06 21:57:38 Re: pg_upgrade test failure
Previous Message Tom Lane 2023-02-06 21:36:07 Re: run pgindent on a regular basis / scripted manner