| From: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | [PATCH] Fix errhint messages for REPACK (CONCURRENTLY) restrictions |
| Date: | 2026-05-12 23:19:13 |
| Message-ID: | CA+fm-RPxX1xTcYY4qQGPRDXB2-Fy2SDNdZi=zVjr0j=MPg2PaA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The errhint messages added by commit 28d534e2ae0 for REPACK (CONCURRENTLY)
restrictions have two issues:
1. They say "REPACK CONCURRENTLY" without parentheses, inconsistent with
the actual command syntax and the errmsg text elsewhere in the same file.
2. The TOAST relations hint is missing a trailing period.
The attached patch fixes both issues and also switches to the %s pattern
so translators handle the template without embedding the SQL command name:
Before:
HINT: REPACK CONCURRENTLY is not supported for TOAST relations
After:
HINT: REPACK (CONCURRENTLY) is not supported for TOAST relations.
Thanks,
Baji Shaik
AWS RDS
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-errhint-messages-for-REPACK-CONCURRENTLY-restric.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Baji Shaik | 2026-05-12 23:26:23 | [PATCH] Fix REPACK decoding worker not cleaned up on FATAL exit |
| Previous Message | Bruce Momjian | 2026-05-12 22:28:54 | Re: Add \pset options for boolean value display |