Re: two small tab-completion patches (ALTER CONSTRAINT, CHECK modifiers)

On Mon, Oct 19, 2026 at 6:33 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:

>
>
> > On Oct 6, 2026, at 05:24, Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> wrote:
>
> After NOT or NO, tab completion doesn’t suggest any further keywords. Here
> is an example from the same file for reference:
> ```
> /* ALTER STATISTICS <name> */
> else if (Matches("ALTER", "STATISTICS", MatchAny))
> COMPLETE_WITH("OWNER TO", "RENAME TO", "SET SCHEMA", "SET
> STATISTICS");
> /* ALTER STATISTICS <name> SET */
> else if (Matches("ALTER", "STATISTICS", MatchAny, "SET"))
> COMPLETE_WITH("SCHEMA", "STATISTICS");
> ```
>
> As you can see, besides suggesting SET SCHEMA and SET STATISTICS, there is
> a separate rule that matches SET and suggests SCHEMA and STATISTICS. I
> think we need similar rules for NOT and NO here. And 0001 has the same
> thing for INITIALLY.
>

ah, thank you so much for the review and guidance to fix, Chao. v2
attached.
Let me know if it still misses anything.

Thanks,
Baji Shaik.