| From: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Zhijie Hou <houzhijie22(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fall back to serializing when parallel apply runs out of DSM segments |
| Date: | 2026-11-11 18:37:23 |
| Message-ID: | CA+fm-RNASnaHTuznFQKEjFn-vpueiBw2quqSta2AWR0GSW97Lg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 11, 2026 at 11:46 AM Bharath Rupireddy <
bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> I have a slightly different opinion here. I understand that a leader
> erroring out while launching parallely apply workers has costs.
> However, DSM running out of segments, IMO, is rare in practice and the
> issue is not reported from the field. Even if it is hit in practice,
> the recovery from that error is automatic for the apply worker starts
> again and callers of make_new_segment() would hit OOM or similar error
> anyway. I would just apply it for HEAD and be done with it.
>
Thanks for the review, Bharath. HEAD only works for me.
I will leave the back-patching decision to the committer.
Thanks,
Baji Shaik
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-11-11 18:40:57 | Re: Pass heap tuple counts to parallel vacuum as double |
| Previous Message | Greg Burd | 2026-11-11 18:14:24 | Re: Hash index: stop registering pin-only bucket pages in WAL (remove REGBUF_NO_CHANGE) |