Re: [HACKERS] Block level parallel vacuum

From: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
To: Mahendra Singh <mahi6run(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Block level parallel vacuum
Date: 2019-12-18 06:17:12
Message-ID: CA+fd4k6sjZvEVaoMDEw92AdHRKBmXXvOWWUHFZKk5UsBdbjA2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 18 Dec 2019 at 03:39, Mahendra Singh <mahi6run(at)gmail(dot)com> wrote:
>
>
> Thanks for updated patches. I verified my all reported issues and all are fixed in v36 patch set.
>
> Below are some review comments:
> 1.
> + /* cap by max_parallel_maintenace_workers */
> + parallel_workers = Min(parallel_workers, max_parallel_maintenance_workers);
>
> Here, spell of max_parallel_maintenace_workers is wrong. (correct: max_parallel_maintenance_workers)
>
> 2.
> + * size of stats for each index. Also, this function Since currently we don't support parallel vacuum
> + * for autovacuum we don't need to care about autovacuum_work_mem
>
> Here, I think, 1st line should be changed because it is not looking correct as grammatically.

Thank you for reviewing and testing this patch. I'll incorporate your
comments in the next version patch.

Regards,

--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-12-18 06:30:22 Re: partition routing layering in nodeModifyTable.c
Previous Message Masahiko Sawada 2019-12-18 06:15:56 Re: [HACKERS] Block level parallel vacuum