| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a typo in slot.c |
| Date: | 2020-05-15 04:37:41 |
| Message-ID: | CA+fd4k6SQadKzq22xrdJhpB18v3P71=n3W6GhZW9tVSVeCbsWA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 15 May 2020 at 13:26, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, May 15, 2020 at 9:16 AM Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > Hi,
> >
> > I've attached the patch for $subject. The old comment seems to be
> > borrowed from WalSndShmemInit().
> >
>
> /*
> - * Allocate and initialize walsender-related shared memory.
> + * Allocate and initialize replication slots' shared memory.
> */
>
> How about changing it to "Allocate and initialize shared memory for
> replication slots"?
>
Agreed.
Attached the updated patch.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| fix_typo_v2.patch | application/octet-stream | 418 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-05-15 04:41:12 | Re: COPY, lock release and MVCC |
| Previous Message | Amit Kapila | 2020-05-15 04:26:36 | Re: Fix a typo in slot.c |