| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Using XLogFileNameP in critical section |
| Date: | 2019-12-03 20:32:41 |
| Message-ID: | CA+fd4k6L9k=61iwOuk2R1h5UzX0aUds-1jgy-Apr9ZBKdHQNSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 3 Dec 2019 at 07:09, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Dec 02, 2019 at 10:14:58PM +0100, Masahiko Sawada wrote:
> > Agreed. I've attached the updated version patch. Please review it.
>
> Thanks, applied on HEAD after a few edits. gettext() does not set
> errno, so the new style of issue_xlog_fsync() is actually fine.
Thanks!
> Please note that there was one mistake in the patch: you forgot to
> assign back errno in assign_xlog_sync_method() after generating the
> file name.
My bad. Thank you for fixing it.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-12-03 21:17:39 | Re: log bind parameter values on error |
| Previous Message | Masahiko Sawada | 2019-12-03 20:30:26 | Re: [HACKERS] Block level parallel vacuum |