| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Claudio Freire <klaussfreire(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: [HACKERS] Block level parallel vacuum |
| Date: | 2020-01-20 03:51:46 |
| Message-ID: | CA+fd4k4YBoVV_optdJoQS+yCks+PtOYb3dbC1rA_cy+0VNNEXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 20 Jan 2020 at 12:39, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jan 17, 2020 at 4:35 PM Mahendra Singh Thalor
> <mahi6run(at)gmail(dot)com> wrote:
> >
> > Below are some review comments for v50 patch.
> >
> > 1.
> > +LVShared
> > +LVSharedIndStats
> > +LVParallelState
> > LWLock
> >
> > I think, LVParallelState should come before LVSharedIndStats.
> >
> > 2.
> > + /*
> > + * It is possible that parallel context is initialized with fewer workers
> > + * then the number of indexes that need a separate worker in the current
> > + * phase, so we need to consider it. See compute_parallel_vacuum_workers.
> > + */
> >
> > This comment is confusing me. I think, "then" should be replaced with "than".
> >
>
> Pushed, after fixing these two comments.
Thank you for committing!
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Prabhu R | 2020-01-20 04:35:58 | Master Master replication |
| Previous Message | Andy Fan | 2020-01-20 03:41:49 | [PATCH] query rewrite for distinct stage under some cases |