| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Resetting spilled txn statistics in pg_stat_replication |
| Date: | 2020-10-15 05:36:46 |
| Message-ID: | CA+fd4k4Rx3rn+fNJG6Yd8+6afnT+u_BwWFo2vNrbVQ3yq4NQJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Oct 2020 at 12:03, Shinoda, Noriyoshi (PN Japan A&PS
Delivery) <noriyoshi(dot)shinoda(at)hpe(dot)com> wrote:
>
> Thanks for your comment.
>
> > 8.3. Character Types:
> > The name type exists only for the storage of identifiers in the internal system catalogs
>
> I didn't know the policy about data types. Thank you.
> But I think the column names should match pg_replication_slots.
> The attached patch changes only the column names and macros.
>
Thank you for updating the patch!
The patch changes the column name from 'name' to 'slot_name' and fixes
a typo. That's reasonable to me. Amit, what do you think?
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2020-10-15 05:37:26 | Re: Online checksums verification in the backend |
| Previous Message | Kyotaro Horiguchi | 2020-10-15 05:30:47 | Re: speed up unicode decomposition and recomposition |