Re: Improve style of list search results

Hi Jonathan,

Thanks for the feedback!

I'm not clear what do you mean with line breaks something like Google, I
suppose that the idea is remove the box border.

I will send new patches soon.

Regards,

On Tue, Jun 5, 2018 at 6:41 AM Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:

> Hi,
>
> On Jun 5, 2018, at 2:52 AM, Jorge Solórzano <jorsol(at)gmail(dot)com> wrote:
>
> Hello pgweb,
>
> This patch improves the style of the list search results giving structure
> and using the Card style of Bootstrap.
>
>
> Thank you for submitting this patch! I have a few comments:
>
> 1. Searches are loaded from two separate files:
>
> - templates/search/listsearch.html
> - templates/search/sitesearch.html
>
> So you would need to apply the markup to both files.
>
> 2. I do like how it makes the topic of the search results a bit larger, but
> I’m worried it’s a bit too large. Easy enough to tone down, I believe.
>
> 3. I’m not a fan of the box border, it does not feel like it flows well
> between the search results. I could make an argument that the box
> does separate the results.
> ​​
> I would prefer if we did something more like
> Google where we had appropriate line breaks.
>
> It also escape content of text to avoid problems with mail outputs that
> gets interpreted as tags.
>
>
> We try to keep our changes atomic, and as such this would
> need to be submitted as a separate patch.
>
> In summary: I think this is in the right direction but needs some work.
>
> Thanks!
>
> Jonathan
>