Re: Popcount optimization for the slow-path lookups

From: Andrew Pogrebnoi <andrew(dot)pogrebnoi(at)percona(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Popcount optimization for the slow-path lookups
Date: 2025-12-05 21:23:13
Message-ID: CA+aWR10Z1_B+_JaN0+n4zhFvaBNcb3tu3H3Y4jpxiy34BzUXaA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 5, 2025 at 5:40 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> I don't think the proposed improvements are relevant for either of the
> machines you used for your benchmarks. For x86, we've optimized our
> popcount code to use SSE4.2 or AVX-512, and for AArch64, we've optimized
it
> to use Neon or SVE. And for other systems, we still try to use
> __builtin_popcount() and friends in the fallback paths, which IIUC are
> available on both gcc and clang (and maybe elsewhere). IMHO we need to
run
> the benchmarks on a compiler/architecture combination where it would
> actually be used in practice.

Yes, I saw that the code is on a rather obscure path, but those machines
were my only options for quick benchmarks.
I reasoned that the code path still exists, and eliminating branching there
would be beneficial anyway
(most probably). But you are right, we need to test it on target
architectures/compilers. I'll try to do with that.

---
Cheers,
Andy

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bryan Green 2025-12-05 21:24:46 Re: [PATCH] Allow complex data for GUC extra.
Previous Message Tom Lane 2025-12-05 20:52:40 Re: More const-marking cleanup