Re: Proposal for enabling auto-vectorization for checksum calculations

From: Stepan Neretin <slpmcf(at)gmail(dot)com>
To: Matthew Sterrett <matthewsterrett2(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>
Subject: Re: Proposal for enabling auto-vectorization for checksum calculations
Date: 2025-05-10 11:01:54
Message-ID: CA+Yyo5Qw=v2bcPSeyGgX3WuHeDXm7vxPcET1n+yUreUmO0rk_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 10, 2025 at 6:01 PM Stepan Neretin <slpmcf(at)gmail(dot)com> wrote:

>
>
> On Thu, May 8, 2025 at 6:57 AM Matthew Sterrett <
> matthewsterrett2(at)gmail(dot)com> wrote:
>
>> Hello! I'm still trying to figure out those CI failures, I just wanted
>> to update things.
>>
>> From my testing, with this patch repeatedly disabling/enabling
>> checksums is about 12.4% on an approximately 15 GB database.
>>
>> By the way, I'd love it if anyone could help me figure out how to
>> replicate a CI failure in the Cirrus CI.
>> I haven't been able to figure out how to test CI runs locally, does
>> anyone know a good method to do that?
>>
>>
>>
> Hi Matthew,
>
> Thanks for the patch!
>
> I ran some timing tests:
>
> (without avx2)
>
> Time: 4034.351 ms
> SELECT drive_pg_checksum(512);
>
> (with avx2)
>
>
> Time: 3559.076 ms
> SELECT drive_pg_checksum(512);
>
> Also attached two patches that should fix the CI issues.
>
> Best,
>
> Stepan Neretin
>
>
>
Oops, forgot to attach patches :)

Best,

Stepan Neretin

Attachment Content-Type Size
v2-0001-Enable-autovectorizing-pg_checksum_block.patch text/x-patch 10.5 KB
v2-0002-Fix-compilation-on-systems-where-immintrin.h-is-n.patch text/x-patch 1.1 KB
v2-0003-Benchmark-code-for-postgres-checksums.patch text/x-patch 4.7 KB
v2-0004-fix-bench-compiling.patch text/x-patch 692 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-05-10 11:08:03 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Previous Message Stepan Neretin 2025-05-10 11:01:06 Re: Proposal for enabling auto-vectorization for checksum calculations