Re: [PATCH v1] Fix tab completion for REINDEX SYSTEM

On Fri, Oct 23, 2026 at 13:39, Sho Ito wrote:
> psql currently offers `CONCURRENTLY` after `REINDEX SYSTEM`, although
> the backend rejects that combination [1].

Hi Sho,

I tested v1 on master (022a80fe6c1) with a readline build.

Before the patch, REINDEX SYSTEM <Tab><Tab> offers CONCURRENTLY, and
CON<Tab> completes to REINDEX SYSTEM CONCURRENTLY, which the server
rejects ("cannot reindex system catalogs concurrently").

With v1, REINDEX SYSTEM offers only database names, including with
parenthesized options and lowercase input, and CON<Tab> no longer
completes to CONCURRENTLY there. The DATABASE, TABLE, INDEX and SCHEMA
forms are unchanged. The psql TAP tests pass and pgindent is clean.

For backpatching: v1 applies as-is to REL_18 and REL_19, and to
REL_15-REL_17 once the file is renamed to tab-complete.c; REL_14 would
need a manual adjustment. These are applicability checks only; I
didn't build or test the stable branches.

Looks good to me.

Thanks,
Ishjaap Singh