Re: BUG #19600: pgcrypto crypt() can return text with invalid encoding

From: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
To: Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>
Cc: malis(at)pgrust(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19600: pgcrypto crypt() can return text with invalid encoding
Date: 2026-11-15 06:39:45
Message-ID: CA+Y2BmeUjDjo7UdRdJu8Fps2uff4-98udM85qTa2Rm3RvkgYjQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi Andrey,

Thanks for v2. It covers both points.

I tested it on master (81b2179b492) with --with-ssl=openssl. The
pgcrypto tests pass in UTF8, LATIN1 and SQL_ASCII databases (crypt-utf8
runs in the first and is skipped in the others). Without the pgcrypto.c
change, all three cases (DES, xDES and MD5) return a hash instead
of the error, so the test catches the bug.

Looks good to me. I'm marking it Ready for Committer.

Thanks,
Ishjaap Singh

In response to

Browse pgsql-bugs by date

  From Date Subject
Previous Message shihao zhong 2026-11-15 05:02:01 Re: BUG #19816: PL/Python SD dictionary is split by input collation in 19rc1