Re: psql: Don't offer partitioned tables after CREATE INDEX CONCURRENTLY

From: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Don't offer partitioned tables after CREATE INDEX CONCURRENTLY
Date: 2026-11-19 16:37:08
Message-ID: CA+Y2Bmc=mUh43JBNwb6qER-ib1tK5cT2_j9yNr-JFApegcgwHg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Álvaro,

Here's v2.

I removed the TailMatches(CONCURRENTLY MatchAny ON) and
TailMatches(CONCURRENTLY ON) rules, and the same CONCURRENTLY forms in
the rules after the table name. CREATE [UNIQUE] INDEX CONCURRENTLY
[name] ON now completes only as a whole command, using Matches(), still
without partitioned tables.

The plain CREATE INDEX rule keeps TailMatches(), but now skips
CONCURRENTLY. Otherwise, when nothing in the CONCURRENTLY list matches
what's typed, completion falls through to TailMatches("INDEX",
MatchAny, "ON"), which takes CONCURRENTLY as the index name and offers
the partitioned tables anyway.

If you'd rather not complete after CREATE INDEX CONCURRENTLY ON at all,
I can drop the Matches() rule and the new query.

Regards,
Ishjaap Singh

Attachment Content-Type Size
v2-0001-psql-Don-t-offer-partitioned-tables-after-CREATE-.patch application/octet-stream 7.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-11-19 16:54:35 Re: [PATCH v1] Add pg_stat_progress overview view
Previous Message Melanie Plageman 2026-11-19 16:36:42 Re: [BUG / PATCH] PG19: VACUUM misestimates reltuples (often 0) after on-access VM setting