Re: [PATCH] Porting small OpenBSD changes.

On 20 November 2017 at 18:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> David CARLIER <devnexen(at)gmail(dot)com> writes:
> > - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if
> > those small changes make sense for the PostgreSQL developers.
>
> Hm. The s_lock.c change is surely fine if OpenBSD maintainers say it is.
>
> Not sure about adding Motorola 88K support to s_lock.h ... is anybody
> really still interested in that platform?

Yes there is :-)

> OTOH, we still have M68K
> and VAX stanzas in that file, so I suppose it's silly to complain
> about 88K. A bigger issue is that I wonder whether that code has
> ever been tested: it does not look to me like the __asm__ call is
> even syntactically correct. There should be colons in it.
>
>
True :-) corrected. Thanks.

> regards, tom lane
>