Re: [PATCH] Porting small OpenBSD changes.

From: David CARLIER <devnexen(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Porting small OpenBSD changes.
Date: 2017-11-20 22:38:37
Message-ID: CA+XhMqwexi1Cq0MBFpRfynNtPb9Qad3mcCzZbrK23O0PvQbK8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I m not against, I would go with your final version too. Thanks !

On 20 November 2017 at 22:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I wrote:
> > I still dare to doubt whether you've tested this, because AFAICS
> > the operand numbering is wrong. The "r"(lock) operand is number 3
> > given these operand declarations, not number 2.
>
> Oh, my apologies, scratch that. Evidently I put in the "+m"(*lock)
> operand and confused myself about what was what.
>
> I still think the form I proposed is better style though.
>
> regards, tom lane
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-11-20 23:03:16 Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.
Previous Message Tom Lane 2017-11-20 22:36:15 Re: [PATCH] Porting small OpenBSD changes.