| From: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix comment in report_sequence_errors() |
| Date: | 2026-06-07 14:35:05 |
| Message-ID: | CA+UBfanz=hfENE8dXugqccsdTX4Qf-eLW2QQUpXC6Yd_v-KW7w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I noticed an incorrect comment in report_sequence_errors() in sequencesync.c.
The function comment describes case (c) as:
```
* c) missing sequences on the subscriber
```
However, the actual warning message emitted and the logic that
populates missing_seqs_idx both refer to sequences that are missing on
the publisher side, not the subscriber.
The fix is to replace "subscriber" with "publisher" in that comment line.
Thanks
Imran Zaheer
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-wrong-comment-in-report_sequence_errors.patch | text/x-patch | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | JoongHyuk Shin | 2026-06-07 10:30:02 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |