| From: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | m(dot)litsarev(at)postgrespro(dot)ru, Ewan Young <kdbase(dot)hack(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix warning: ‘startpos’ may be used uninitialized in function ‘results_differ’ |
| Date: | 2026-06-18 06:26:56 |
| Message-ID: | CA+UBfam1Yyo6SfScRSaGVa_Vo6tpoV1Pkb5qHD-Oxdj=5CrF5Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I also reported [1] some similar warnings emitted from the old gcc
some time ago. Do you think this should be worth getting fixed?
Thanks
Imran Zaheer
[1]: https://www.postgresql.org/message-id/flat/CA+UBfa=H9RQdZ8Tof+SF7gMC-FTrsJ_w=Vnxs4OiBAaB_go+tQ(at)mail(dot)gmail(dot)com<span
class="sewitjdq8nk9iqz"></span>
On Wed, Jun 17, 2026 at 11:03 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 16/06/2026 18:22, m(dot)litsarev(at)postgrespro(dot)ru wrote:
> >> ...I propose the attached, to bail out if the fopen() fails. (As the
> >> original patch, this looks a lot smaller with "diff -w")
> > I agree the v2 patch is even better.
>
> Committed, thanks!
>
> - Heikki
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-06-18 06:27:42 | Re: Fix tuple deformation with virtual generated NOT NULL columns |
| Previous Message | Chao Li | 2026-06-18 06:25:03 | Re: pgbench --continue-on-error: clarify TPS and failure reporting |