| From: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Silence -Wmaybe-uninitialized warnings |
| Date: | 2026-04-02 09:49:51 |
| Message-ID: | CA+UBfa=H9RQdZ8Tof+SF7gMC-FTrsJ_w=Vnxs4OiBAaB_go+tQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
When building postgresql with CFLAGS="-Og" gcc emits
'-Wmaybe-uninitialized' warnings at few places. The variables are
initialized on all execution paths but the compiler was not able to
prove it with the additional optimization flag enabled. The patch
initializes the variables with NULL to silence the warnings. No
functional change intended.
```
[646/2085] Compiling C object
src/backend/postgres_lib.a.p/commands_copyfromparse.c.o
../src/backend/commands/copyfromparse.c: In function ‘CopyFromTextOneRow’:
../src/backend/commands/copyfromparse.c:995:39: warning:
‘field_strings’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
995 | string = field_strings[fieldno++];
| ^
../src/backend/commands/copyfromparse.c:961:21: note: ‘field_strings’
was declared here
961 | char **field_strings;
| ^~~~~~~~~~~~~
../src/backend/commands/copyfromparse.c: In function ‘CopyFromCSVOneRow’:
../src/backend/commands/copyfromparse.c:995:39: warning:
‘field_strings’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
995 | string = field_strings[fieldno++];
| ^
../src/backend/commands/copyfromparse.c:961:21: note: ‘field_strings’
was declared here
961 | char **field_strings;
| ^~~~~~~~~~~~~
[889/2085] Compiling C object
src/backend/postgres_lib.a.p/partitioning_partbounds.c.o
../src/backend/partitioning/partbounds.c: In function
‘check_partition_bounds_for_split_range’:
../src/backend/partitioning/partbounds.c:5452:57: warning: ‘datum’ may
be used uninitialized in this function [-Wmaybe-uninitialized]
5452 |
parser_errposition(pstate, exprLocation((Node *) datum)));
|
```
gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0
Regards
Imran Zaheer
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Silence-Wmaybe-uninitialized-warnings.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-04-02 10:11:07 | Re: Fix HAVING-to-WHERE pushdown with nondeterministic collations |
| Previous Message | Heikki Linnakangas | 2026-04-02 09:27:51 | Re: Changing the state of data checksums in a running cluster |